modifications to dart.h and vterbi.cpp files - #4

Thanks for this! I see this unmerged PR in the upstream MeCab repo from a year ago taku910/mecab#66 so I'm happy to accept the fix to get this to compile as C++17.

In order to keep the differences with the upstream/original C++ code as minimal as possible though, can I beg you to revert your clang-format changes?

Let me know, if you're busy I can try to undo the whitespace changes, keeping just the register changes and maybe the new test case (I can't easily see the test in the diff).

Again, thank you!

Aiite will revert.

Hi will work on this. been very busy with work

I just fixed the clangtidy formatted files

Thanks! Could you help me understand the rewrite of src/viterbi.cpp? It looks like calc_alpha and Viterbi::forwardbackward and several other functions were removed, were these unused…?

Also, I see that your taku910/mecab#66 has a really small diff, do you think I could just merge that patch into this repo?

Thanks! Could you help me understand the rewrite of src/viterbi.cpp? It looks like calc_alpha and Viterbi::forwardbackward and several other functions were removed, were these unused…?

Also, I see that your taku910/mecab#66 has a really small diff, do you think I could just merge that patch into this repo?

oh so sorry about that, its a mix up from my end. will resolve that asap